-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ray.tune
usage example.
#209
Conversation
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 92.22% 92.24% +0.01%
==========================================
Files 48 48
Lines 3345 3351 +6
==========================================
+ Hits 3085 3091 +6
Misses 260 260
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the concern about removal of example dependencies.
pip install -r examples/examples_requirements.txt # Installs other example requirements | ||
|
||
The dependencies can also be installed individually as required. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remove the example related dependencies? I don't think these are there anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a continual pain until #195 is addressed. I'll fix manually for now.
@@ -1,5 +1,5 @@ | |||
# -*- coding: utf-8 -*- | |||
# Copyright (C) 2021 by SCICO Developers | |||
# Copyright (C) 2021-2022 by SCICO Developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other files, should the end year be the current year or the year the file was last edited on?
In the long-term, should we manually update these or should we make a script (say in scico/misc) that updates these automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that the end year should correspond to the year of most recent edit. I think we can live with manual updates for now.
Improve
ray.tune
usage example. Also:scico.ray.tune
wrapper.scico.ray.tune
.ray.tune
usage example to examples index.